Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added functionality to download geofences and rallypoints #2404

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

mattes-bru
Copy link
Contributor

mainly a copy & paste of download_mission for rallypoints and geofence. Which solves my issue #2403

Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattes-bru
Copy link
Contributor Author

I have completely forgotten the protobuf part.

Now I updated the proto files but when I generate the code as mentioned in the link the code style changes and so there are many updates, I don't want to commit. I also ran the fix-style.sh script but this did not help.

@mattes-bru mattes-bru marked this pull request as draft September 26, 2024 11:54
@mattes-bru mattes-bru marked this pull request as ready for review September 27, 2024 08:40
@julianoes
Copy link
Collaborator

I think this looks all fine. It's just complaining about one style problem. I'll try to run the script again.

@julianoes
Copy link
Collaborator

I'll squash and merge this as soon as CI is green.

Copy link

@julianoes julianoes merged commit 0b564f0 into mavlink:main Sep 30, 2024
36 checks passed
@mattes-bru
Copy link
Contributor Author

@julianoes is it possible to get this into a v2 release?

@julianoes
Copy link
Collaborator

I'd rather not have to deal with a v2 proto branch if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants