Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more video streaming info #2231

Closed
wants to merge 3 commits into from
Closed

Conversation

tbago
Copy link
Contributor

@tbago tbago commented Feb 23, 2024

  • unify the camera and camera server stream info;
  • support multi camera video stream info;
  • add camera video stream info usage example;

@@ -506,11 +506,6 @@ Camera::Result CameraImpl::stop_video()
{
auto cmd_stop_video = make_command_stop_video();

{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stop video just mean stop recording video to file, so not need stop video streaming.

@tbago tbago force-pushed the add_video_stream_info branch 2 times, most recently from 9e9c4bc to 502619b Compare February 26, 2024 03:41
 * unify the camera and camera server stream info;
 * support multi camera video stream info;
 * add camera video stream info usage example;
@tbago tbago force-pushed the add_video_stream_info branch from 502619b to 02853b2 Compare February 27, 2024 02:19
 * unify camera information in camera and camera server;
 * add camera cap flags in camera and camera server;
 * add basic example about camera information;

for (const auto& elem : information.camera_cap_flags()) {
obj.camera_cap_flags.push_back(translateFromRpcCameraCapFlags(
static_cast<mavsdk::rpc::camera::Information::CameraCapFlags>(elem)));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the auto generate code is static_castmavsdk::rpc::camera::CameraCapFlags missing Information domain. I just manual add Information in auto generate code.

@@ -169,6 +261,11 @@ class CameraServerServiceImpl final : public rpc::camera_server::CameraServerSer

obj.definition_file_uri = information.definition_file_uri();

for (const auto& elem : information.camera_cap_flags()) {
obj.camera_cap_flags.push_back(translateFromRpcCameraCapFlags(
static_cast<mavsdk::rpc::camera_server::Information::CameraCapFlags>(elem)));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the auto generate code is static_castmavsdk::rpc::camera_server::CameraCapFlags missing Information domain. I just manual add Information in auto generate code.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots
45.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@tbago tbago closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant