Add periodic refresh for connection #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `refresh_interval_seconds` to Meta's config.
javiercr
commented
May 9, 2024
tulir
reviewed
May 9, 2024
javiercr
force-pushed
the
feature/periodic-refresh
branch
from
a984cbd
to
cc36414
Compare
… and use `FullReconnect` for force refreshes
javiercr
force-pushed
the
feature/periodic-refresh
branch
from
cc36414
to
23ab631
Compare
javiercr
commented
May 15, 2024
| @@ -95,6 +95,10 @@ meta: | |||
| # HTTP endpoint to request new proxy address from, for dynamically assigned proxies. | |||
| # The endpoint must return a JSON body with a string field called proxy_url. | |||
| get_proxy_from: | |||
| # Minimum interval between full reconnects in seconds, default is 1 hour | |||
| min_full_reconnect_interval_seconds: 3600 | |||
There was a problem hiding this comment.
I'm exposing MinFullReconnectIntervalSeconds in the config file, as it also affect the interval for force refreshes.
tulir
reviewed
May 15, 2024
… goes wrong while connecting
tulir
approved these changes
May 15, 2024
Co-authored-by: Tulir Asokan <[email protected]>
This was referenced May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've observed a number of intermittent errors where the socket connection is closed while trying to send a message (
refresh error; please retry in a few minutes).Until we figure out why that's happening, this should help mitigate those problems by refreshing the connection at a given interval.