Update permissions of temporary file because the native imessage agent on iOS doesn't have root permissions #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t on iOS doesn't have root permissions
|
@EricRabil / @tulir would one of you review this? Have this running since a few days now and haven't found any issues or crashes around attachments yet |
tulir
reviewed
Feb 22, 2022
|
@tulir updated the PR to have different permissions depending on if it's built for mac or iOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for filing #43, this turned out to be a red herring. After the PR was closed I had no other way of getting this build than setting up the local iMessage go build environment myself, so I went ahead and did that last night.
When testing out, I learned that the deletion of the file isn't the issue, but rather that on iOS the IMFileTransferCenter daemon doesn't run as root user (obviously) and hence isn't able to read the temp folder with
700permissions created as root.After changing both the temp folder permissions, as well as the file permissions sending images from matrix via Barcelona to iMessage works like a charm.