Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to Edit and Unsend Messages for BlueBubbles Bridge #203

Merged
merged 15 commits into from
Mar 25, 2024

Conversation

joshuafhiggins
Copy link
Contributor

Implements #190 and #191

This works by telling Beeper that it is the imessagego bridge that had implemented edits and unsends before. This is not ideal to use an unsupported bridge's ID and we should probably ask if Beeper could give BlueBubbles its own Protocol.ID. This is my first time working in golang so let me know if any changes are needed. I've only ran some initial tests and the features seem to work with this, but again let me know.

Make names consistent for what unsending is
Is there a way to not require this function to be here for people that don't have the capibility?
@dltacube
Copy link
Collaborator

Oh this is hilarious. I don't know how the others will react to this but I think it'd have a better chance of getting merged if it was setup as an optional feature.

@joshuafhiggins
Copy link
Contributor Author

Oh this is hilarious. I don't know how the others will react to this but I think it'd have a better chance of getting merged if it was setup as an optional feature.

I was wondering if there was a way to add it to the API but not require the other bridge types to implement them, I'll look into it.

@trek-boldly-go
Copy link
Collaborator

@joshuafhiggins I haven't tested this but the code looks fairly straightforward and clean. I am not concerned about the "false" reporting of the bridge type, because it was already doing that to enable the tapback features. I'll try to test it early this upcoming week and get it merged for a real pre-release review (along with the other features I have ready to merge).

@trek-boldly-go
Copy link
Collaborator

I'll be darned, it actually works. Unfortunately I ran a delete before I started the bridge with your changes, so I don't know whether it requires a delete to make the features available in beeper.

@trek-boldly-go trek-boldly-go merged commit 1fcdf17 into mautrix:development Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants