using any over interface{} #189
Conversation
|
I just realized there are exceptions when it comes to initialism in cases where the variable or function's scope needlessly changes from the original authors intent. Will fix that. |
This reverts commit 2c1a437.
dltacube
requested review from
cnuss,
trek-boldly-go and
tulir
as code owners
|
I reverted this commit but do we want to make changes like this here that change the scope of the function? 2c1a437 |
|
@tulir I think GH is going to require an approval from you on this one. I think it is the edit to the tapbacks file that triggered it. |
This reverts commit 435a6db.
| @@ -1227,12 +1227,12 @@ func (bb *blueBubbles) wsUrl() string { | |||
| q.Add("transport", "websocket") | |||
| u.RawQuery = q.Encode() | |||
|
|
|||
| url := u.String() | |||
| URL := u.String() | |||
There was a problem hiding this comment.
Local variables (and in general anything that isn't exported from the package) should start with lowercase, so this was correct already before
There was a problem hiding this comment.
I noticed I was changing the scope on some variables with this commit (and undid that change) 0df68f5 but missed this one.
I'll refactor that so we're not unintentionally exporting anything.
There was a problem hiding this comment.
Variables inside functions are never exported, so having them start with uppercase is always wrong
There was a problem hiding this comment.
Oh I see, even if they're an initial. Thanks for clarifying that!
There was a problem hiding this comment.
This PR should address it: #194
Changelist
convert
interface{}toanyrefconvert
time.Millisecondtotime.UnixMilli()refsomething something initialisms ref
refactor for reconnect ref initial implementation: adding retry timer #188
Gonna move these to another PR