-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send queued webhooks in reversed chronological order #4627
Merged
Gregy
merged 8 commits into
mautic:staging
from
escopecz:enhancement-webhook-q-reversed-chronological-order
Aug 24, 2017
Merged
Send queued webhooks in reversed chronological order #4627
Gregy
merged 8 commits into
mautic:staging
from
escopecz:enhancement-webhook-q-reversed-chronological-order
Aug 24, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omply with Zapier's deduplication rules
escopecz
added
feature
A new feature for inclusion in minor or major releases
ready-to-test
PR's that are ready to test
labels
Aug 9, 2017
escopecz
added
WIP
PR's that are not ready for review and are currently in progress
and removed
ready-to-test
PR's that are ready to test
labels
Aug 9, 2017
escopecz
added
ready-to-test
PR's that are ready to test
and removed
WIP
PR's that are not ready for review and are currently in progress
labels
Aug 10, 2017
This was referenced Aug 10, 2017
…lue will be created via API
dongilbert
approved these changes
Aug 22, 2017
dongilbert
added
pending-test-confirmation
PR's that require one test before they can be merged
and removed
ready-to-test
PR's that are ready to test
labels
Aug 23, 2017
Gregy
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
A new feature for inclusion in minor or major releases
pending-test-confirmation
PR's that require one test before they can be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Zapier requires to send queued webhook entities in reversed chronological order:
https://zapier.com/developer/documentation/v2/deduplication/
To keep BC, this PR adds 2 new options to configure the order. One is in the Mautic configuration and that option is taken as a default one for all webhooks. The default value of that field is ASC, so it will work as before.
Another option is to configure the order for every webhook. That's what we need for Zapier.
Steps to test this PR:
dateModified
is oldest at the top and latest at the bottom.