Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on PHP 8.1 as Mautci 5.2 dropps support for 8.0 #328

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

escopecz
Copy link
Member

@escopecz escopecz commented Aug 30, 2024

At some point we should use DDEV env for running Mautic so the 2 repos are independent.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.22%. Comparing base (622e15f) to head (c219a40).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #328   +/-   ##
=========================================
  Coverage     53.22%   53.22%           
  Complexity      396      396           
=========================================
  Files            30       30           
  Lines          1054     1054           
=========================================
  Hits            561      561           
  Misses          493      493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@patrykgruszka patrykgruszka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍

@escopecz escopecz merged commit 2a8c988 into mautic:main Aug 30, 2024
4 checks passed
@escopecz escopecz deleted the test-in-php8.1 branch August 30, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants