Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPSTAN #325

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Add PHPSTAN #325

merged 3 commits into from
Jul 18, 2024

Conversation

matbcvo
Copy link
Contributor

@matbcvo matbcvo commented Jul 18, 2024

This PR supersedes an earlier attempt to integrate PHPSTAN, which encountered conflicts. The conflicts have been resolved in this updated implementation.

@RCheesley
Copy link
Member

Thanks @matbcvo - I have just set the tests running! 🤞

@RCheesley
Copy link
Member

@all-contributors please add @matbcvo for code, tests

Copy link
Contributor

@RCheesley

I've put up a pull request to add @matbcvo! 🎉

@matbcvo
Copy link
Contributor Author

matbcvo commented Jul 18, 2024

@RCheesley Could you please set tests run again?

Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great. Most of them are in tests and not a production code. The one change in the production code makes sense 👍 Thank you!

@escopecz escopecz merged commit c1ae7f7 into mautic:main Jul 18, 2024
2 checks passed
@matbcvo matbcvo deleted the phpstan branch July 18, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants