-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPMMA-2550 Point Groups API #322
DPMMA-2550 Point Groups API #322
Conversation
I'll close and reopen this PR to retrigger GH Actions to run on the branch where your changes are present to see if it will pass now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
============================================
+ Coverage 52.49% 53.12% +0.62%
- Complexity 390 397 +7
============================================
Files 30 30
Lines 1042 1056 +14
============================================
+ Hits 547 561 +14
Misses 495 495 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you missed the getPointGroupScores()
method from the tests. Could you add it? Also, look at the param and return type. I see some room for improvement there.
Sure, should be fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It's good to go 👍
@mollux can you remind me if we are merging M5 PRs to the main or another branch?
We should merge this one, API docs uses examples from this library - mautic/developer-documentation-new#185 |
API library changes for mautic/mautic#13517