Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPMMA-2550 Point Groups API #322

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

patrykgruszka
Copy link
Member

API library changes for mautic/mautic#13517

@escopecz
Copy link
Member

I'll close and reopen this PR to retrigger GH Actions to run on the branch where your changes are present to see if it will pass now.

@escopecz escopecz closed this Apr 29, 2024
@escopecz escopecz reopened this Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.12%. Comparing base (81fd0f4) to head (9b0639e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #322      +/-   ##
============================================
+ Coverage     52.49%   53.12%   +0.62%     
- Complexity      390      397       +7     
============================================
  Files            30       30              
  Lines          1042     1056      +14     
============================================
+ Hits            547      561      +14     
  Misses          495      495              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you missed the getPointGroupScores() method from the tests. Could you add it? Also, look at the param and return type. I see some room for improvement there.

@patrykgruszka
Copy link
Member Author

Sure, should be fine now.

Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's good to go 👍

@mollux can you remind me if we are merging M5 PRs to the main or another branch?

@patrykgruszka
Copy link
Member Author

We should merge this one, API docs uses examples from this library - mautic/developer-documentation-new#185

@escopecz escopecz merged commit 8e68ea9 into mautic:main Jul 9, 2024
5 of 6 checks passed
@RCheesley RCheesley added this to the 4.0 milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants