Fix getMauticVersion() accessing lower-case headers as array-key #302
Conversation
…ey (addresses issue mautic#233)
|
@escopecz Currently this fix is not available in the current version of 3.1, which breaks OAuth2 again if a reverse-proxy is used somewhere in the server setup. Will it be available later if you rebasing the 3.x branch with 2.x or do we need a new PR? |
|
I'm looking at the changes that were merged already and there are some BC breaks. So we'll have to release it as new major version (4.0). I'm currently focusing on getting Mautic 5 released so I won't have time to get this repository prepared for new major release in next few months. Do you have some time give this library some love? There are other great PRs that are waiting for review and tests. If you or anyone else would like to be on the maintenance team for this repo, please let me or @RCheesley know. As a way around this issue you can use the main branch in your composer.json instead of a tagged version to get use the unreleased changes in your app. |
|
I haven't seen that v3 was branched off from main before this PR, so all good I think. Regarding maintaining: its a bit difficult as I'm pretty busy already spending the few hours I have on So yes, if I can help to test something to bring forward a minimal PHP 8 release, I will do what I can. It would be helpful to have a list of most-wanted/most-important PRs or features to focus on. |
|
@Moongazer I had a chat with @mollux yesterday and he's planning to make a new major version (4-alpha) while keeping the 3.x version still alive. I'm sure Mattias will reach out if he'll need some help here and there. Right now he's trying to get #288 in for the 4-alpha version so if you could give another review/test that'd be great. |
Fixes #233
Ensures that the mautic-version header key is always converted to lowercase prior to checking if it exists. This makes the getMauticVersion() command less error-prone, e.g. if Nginx is used as reverse-proxy which convertes HTTP headers to lower-case.