Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the test flow compatible with removed email step #300

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Apr 18, 2023

As the e-mail step was removed from mautic/mautic (see mautic/mautic#12216), the tests need to be adapted in this repo, to be able to install Mautic correctly.

This PR addresses this

@cla-bot cla-bot bot added the cla-signed label Apr 18, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #300 (b2943a2) into main (1b82b46) will not change coverage.
The diff coverage is n/a.

❗ Current head b2943a2 differs from pull request most recent head 7c049d7. Consider uploading reports for the commit 7c049d7 to get more accurate results

@@            Coverage Diff            @@
##               main     #300   +/-   ##
=========================================
  Coverage     52.05%   52.05%           
  Complexity      407      407           
=========================================
  Files            30       30           
  Lines          1093     1093           
=========================================
  Hits            569      569           
  Misses          524      524           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mollux mollux requested a review from escopecz April 18, 2023 07:25
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You rock! 👍

@escopecz escopecz merged commit 8c9cade into mautic:main Apr 18, 2023
@mollux mollux deleted the fix-tests branch April 18, 2023 07:46
@RCheesley RCheesley added this to the 4.0 milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants