Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove composer.lock #299

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Remove composer.lock #299

merged 1 commit into from
Apr 19, 2023

Conversation

JaZo
Copy link
Contributor

@JaZo JaZo commented Apr 14, 2023

As discussed in #272 (comment)

@cla-bot cla-bot bot added the cla-signed label Apr 14, 2023
@escopecz
Copy link
Member

Thanks! This is good to go but blocked by https://github.com/mautic/api-library/pull/290/files#r1168363521

@escopecz
Copy link
Member

Could you please rebase? The tests are fixed in the latest main branch

@JaZo
Copy link
Contributor Author

JaZo commented Apr 18, 2023

Check, here you go!

@codecov-commenter
Copy link

Codecov Report

Merging #299 (3436d69) into main (8c9cade) will not change coverage.
The diff coverage is n/a.

❗ Current head 3436d69 differs from pull request most recent head 83a65f7. Consider uploading reports for the commit 83a65f7 to get more accurate results

@@            Coverage Diff            @@
##               main     #299   +/-   ##
=========================================
  Coverage     52.05%   52.05%           
  Complexity      407      407           
=========================================
  Files            30       30           
  Lines          1093     1093           
=========================================
  Hits            569      569           
  Misses          524      524           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@escopecz escopecz merged commit 5407d71 into mautic:main Apr 19, 2023
@JaZo JaZo deleted the feature/remove-composer-lock branch April 19, 2023 09:24
@RCheesley RCheesley added this to the 4.0 milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants