Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct mautic env #284

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Correct mautic env #284

merged 2 commits into from
Sep 27, 2022

Conversation

mollux
Copy link
Contributor

@mollux mollux commented Sep 27, 2022

Since mautic/mautic#11498 was merged, the api tests seems to fail.

This is caused because Mautic is installed in the test env (using md5 hashing for passwords), but is consumed in the dev env using bcrypt.

This PR ensures Mautic is installed in dev env

@cla-bot cla-bot bot added the cla-signed label Sep 27, 2022
@mollux mollux force-pushed the correct_mautic_env branch 2 times, most recently from bcba2fb to f608946 Compare September 27, 2022 07:20
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for taking care of this!

@escopecz escopecz merged commit 228d55c into mautic:main Sep 27, 2022
@mollux mollux deleted the correct_mautic_env branch September 27, 2022 07:59
@escopecz
Copy link
Member

@all-contributors please add @mollux for code

@allcontributors
Copy link
Contributor

@escopecz

I've put up a pull request to add @mollux! 🎉

@RCheesley RCheesley added this to the 4.0 milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants