Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure strlen is not called with NULL values to avoid a deprecation w… #281

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Ensure strlen is not called with NULL values to avoid a deprecation w… #281

merged 1 commit into from
Sep 16, 2022

Conversation

dlopez-akalam
Copy link
Contributor

Closes #280

@cla-bot
Copy link

cla-bot bot commented Sep 15, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: David Lopez.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Sep 15, 2022

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @dlopez-akalam.

Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@escopecz
Copy link
Member

@dlopez-akalam please sign CLA so this could be merged.

@codecov-commenter
Copy link

Codecov Report

Merging #281 (246c1ec) into main (0d1de9f) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main     #281   +/-   ##
=========================================
  Coverage     49.94%   49.94%           
- Complexity      407      408    +1     
=========================================
  Files            30       30           
  Lines           973      973           
=========================================
  Hits            486      486           
  Misses          487      487           
Impacted Files Coverage Δ
lib/Auth/OAuth.php 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dlopez-akalam
Copy link
Contributor Author

dlopez-akalam commented Sep 16, 2022

Hi @escopecz, I signed the agreement yesterday. I wonder it takes a few days to be validated.

@escopecz
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Sep 16, 2022
@cla-bot
Copy link

cla-bot bot commented Sep 16, 2022

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

@escopecz escopecz merged commit a7b8d09 into mautic:main Sep 16, 2022
@escopecz
Copy link
Member

@all-contributors please add @dlopez-akalam for code

@allcontributors
Copy link
Contributor

@escopecz

I've put up a pull request to add @dlopez-akalam! 🎉

@RCheesley RCheesley added this to the 4.0 milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated error on isOauth1 function using php8.1
5 participants