Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Allow also newer versions of psr/log #270

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Conversation

jonnitto
Copy link
Contributor

This will close #268

@cla-bot
Copy link

cla-bot bot commented Apr 19, 2022

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @jonnitto.

@RCheesley
Copy link
Member

@cla-bot check

Thanks for the PR @jonnitto and for signing the contributors agreement! Welcome to the community! 🚀

@cla-bot cla-bot bot added the cla-signed label Apr 19, 2022
@cla-bot
Copy link

cla-bot bot commented Apr 19, 2022

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

@jonnitto
Copy link
Contributor Author

Can someone start the workflow approval? Thanks!

Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! 👍

@codecov-commenter
Copy link

Codecov Report

Merging #270 (c75d0e5) into main (7478f55) will decrease coverage by 1.66%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #270      +/-   ##
============================================
- Coverage     51.45%   49.79%   -1.67%     
  Complexity      406      406              
============================================
  Files            30       30              
  Lines          1028      970      -58     
============================================
- Hits            529      483      -46     
+ Misses          499      487      -12     
Impacted Files Coverage Δ
lib/Api/Stats.php 23.07% <0.00%> (-18.10%) ⬇️
lib/Api/Contacts.php 90.38% <0.00%> (-2.68%) ⬇️
lib/Auth/AbstractAuth.php 73.33% <0.00%> (-0.87%) ⬇️
lib/QueryBuilder/WhereBuilder.php 90.00% <0.00%> (-0.48%) ⬇️
lib/Auth/OAuth.php 0.00% <0.00%> (ø)
lib/Api/Api.php 78.22% <0.00%> (+0.12%) ⬆️
lib/QueryBuilder/QueryBuilder.php 54.05% <0.00%> (+2.77%) ⬆️
lib/Api/CampaignEvents.php 70.00% <0.00%> (+10.00%) ⬆️
lib/Api/Forms.php 33.33% <0.00%> (+17.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7478f55...c75d0e5. Read the comment docs.

@escopecz escopecz merged commit 1428308 into mautic:main Apr 20, 2022
@jonnitto jonnitto deleted the psr_log branch April 23, 2022 17:15
@escopecz
Copy link
Member

escopecz commented May 9, 2022

FYI I'm reverting changes in composer.lock from this PR in #272 and making just the necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of newer psr/log (v2 & v3)
4 participants