Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow testing specific PR in Actions workflow #256

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Conversation

dennisameling
Copy link
Member

@dennisameling dennisameling commented Jul 14, 2021

Closes #255

After merging this PR, then manually kicking off the API library tests, it will be possible to specify a specific PR from mautic/mautic to test against 🎉

image

Example run which tests against mautic/mautic#10259: https://github.com/mautic/api-library/actions/runs/1030643520

@dennisameling dennisameling added the chore Tasks that relate to maintaining this Github repository label Jul 14, 2021
@dennisameling dennisameling requested a review from RCheesley July 14, 2021 14:35
@cla-bot cla-bot bot added the cla-signed label Jul 14, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #256 (5019c00) into main (5cda363) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #256   +/-   ##
=========================================
  Coverage     51.45%   51.45%           
  Complexity      406      406           
=========================================
  Files            30       30           
  Lines          1028     1028           
=========================================
  Hits            529      529           
  Misses          499      499           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cda363...5019c00. Read the comment docs.

@dennisameling
Copy link
Member Author

mautic/mautic#10023 fixes the API library tests (see https://github.com/mautic/api-library/runs/3068060332?check_suite_focus=true), so this PR can be merged either before or after that PR has been merged 👍🏼

Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 👏

@RCheesley
Copy link
Member

Thanks for the PR @dennisameling - super helpful feature! LGTM!

@RCheesley RCheesley merged commit 9087dde into main Jul 15, 2021
@dennisameling dennisameling deleted the workflow-dispatch branch July 15, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Tasks that relate to maintaining this Github repository cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow running API library tests against specific mautic/mautic PR
4 participants