Switch to GitHub actions #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisameling
changed the title
|
Nice! I can see some failed tests. Since most of them are from |
|
Twilio/SMS tests fixed, will look into the other ones during the weekend. |
|
Note to self: change |
dennisameling
force-pushed
the
switch-to-github-actions
branch
from
9e0be28 to
db9f1e0
Compare
|
Note to self: seeing this in the log artifacts, fixing this will potentially fix the failing email tests: |
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
=========================================
Coverage 51.45% 51.45%
Complexity 406 406
=========================================
Files 30 30
Lines 1028 1028
=========================================
Hits 529 529
Misses 499 499 Continue to review full report at Codecov.
|
|
@escopecz this should be good to go now 😊 would you mind checking the code so we can get this merged? Thanks! |
dennisameling
changed the title
dennisameling
commented
Jan 26, 2021
| options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3 | ||
|
|
||
| mailhog: | ||
| image: mailhog/mailhog:latest |
There was a problem hiding this comment.
Using MailHog so it will catch emails - without this, the email tests will fail
dennisameling
commented
Jan 26, 2021
| uses: rtCamp/action-slack-notify@v2 | ||
| if: ${{ failure() && github.event_name == 'schedule' }} | ||
| env: | ||
| SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} |
There was a problem hiding this comment.
Note to self: waiting for @alanhartless to approve my Slack webhook request in the Slack workspace 😊
There was a problem hiding this comment.
Secret SLACK_WEBHOOK has now been added to this repo 🚀 ✔️
dennisameling
commented
Jan 26, 2021
| pull_request: | ||
| schedule: | ||
| # Run every day at 10 AM UTC to discover potential issues with recent changes to Mautic itself | ||
| - cron: '0 10 * * *' |
There was a problem hiding this comment.
Hopefully this cron will allow us to discover potential issues with recent merges in mautic/mautic much earlier than we can now
|
Merging this PR after checking with @RCheesley 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since travis-ci.org will be shutdown on December 31st, we either need to move to travis-ci.com (where a credit limit applies) or move to GH Actions. We just did the latter with
mautic/mautic, so with this PR I'm doing the same for the API library.