Better handling of bad responses, Response class started, tests added #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanhartless
suggested changes
Nov 17, 2017
lib/Response.php
Outdated
| $parsed = $this->decodeFromJson(); | ||
| } catch (UnexpectedResponseFormatException $e) { | ||
| $parsed = $this->decodeFromUrlParams(); | ||
| die(var_dump($parsed)); |
There was a problem hiding this comment.
Assuming this is debug code.
|
|
||
| if (empty($message)) { | ||
| // Use message appropriate to the subclass with late binding | ||
| $message = static::DEFAULT_MESSAGE; |
There was a problem hiding this comment.
Should this be self? Don't see a need for late static bindings here.
alanhartless
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the HTML response responsibility from
AbstractAuthto newResponseclass. It improves testability and the tests are part of this PR.This PR also slightly changes the behavior. I don't consider it a BC break but bug fix.
UnexpectedResponseFormatExceptionis thrown. This exception was previously thrown only if HTTP code was not 200 or 201.UnexpectedResponseFormatExceptionhas first new param and that is the new Response class so it could build a more detailed error message out of it. That can be considered to be BC, but exceptions from this library should not be thrown in code outside of this library.