Skip to content

Conversation

@mollux
Copy link

@mollux mollux commented May 12, 2024

This fixes errors like

php.CRITICAL: Uncaught Error: LightSaml\SpBundle\Controller\DefaultController::__construct(): Argument #1 ($metadataProfileBuilder) not passed {"exception":"[object] (ArgumentCountError(code: 0): LightSaml\\SpBundle\\Controller\\DefaultController::__construct(): Argument #1 ($metadataProfileBuilder) not passed at /var/www/html/vendor/lightsaml/sp-bundle/src/LightSaml/SpBundle/Controller/DefaultController.php:29)"} {"hostname":"xxx","pid":46}

see e.g. mautic/mautic#13361

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the +1 on the mautic/mautic PR, giving the +1 here too.

@mollux mollux merged commit 083bf6d into symfony5 May 31, 2024
@mollux
Copy link
Author

mollux commented May 31, 2024

Merging this based on the feedback, so we can use this updated dependency in mautic/mautic

@escopecz escopecz deleted the fix/add-missing-service-arguments branch June 5, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants