-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first version of libdirsearch #960
base: master
Are you sure you want to change the base?
Conversation
@InsaneMiner How this will be used as a lib? What is the syntax? |
@shelld3v this is a example file If you don't like it i can change it |
Hello @InsaneMiner Please join the Slack Channel https://join.slack.com/t/dirsearch/shared_invite/zt-vg2tsxqe-RtqcPkMnNXu9l9tyybpRnw |
ok |
self.report_manager.update_report(self.report) | ||
exit(0) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are too many new lines here, please follow pep8 rules: https://www.python.org/dev/peps/pep-0008/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, what is the difference between Controller
and LibController
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, what is the difference between
Controller
andLibController
?
I think so, i can't remember
|
||
dirsearch.run(args) | ||
|
||
print(dfh.dirs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All files should be ended with a new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I would like to rename the folder to examples
, as in the future there will be more examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I would like to rename the folder to
examples
, as in the future there will be more examples
ok
Hi, can we move stuff inside |
More about your PR's linting issues can be found here: https://github.com/maurosoria/dirsearch/pull/960/checks?check_run_id=3727897089 |
yeah |
Description
What will it do?
This is the first version of the libdirsearch. This allows you to use dirsearch as a lib. This is the first version so i have not made it perfect. If anyone has ideas what i should add then please make a new issue.
If this PR will fix an issue, please address it:
Fix #{issue}
Requirements
CONTRIBUTERS.md
CHANGELOG.md