Rename IsIterable to IsIterator #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Either way is fine. But the earliest I would tag a new version is the end of the week as there was a lot of churn for Tony to work through recently. |
|
No worry about timing, I'm happy if this is just on |
|
Thanks! |
|
@mauro3 Actually, any chance you could tag a version now? I'm essentially at a point where I could release a lot of stuff that uses this. |
mauro3
added a commit
that referenced
this pull request
Aug 10, 2017
I'm a bit stomped by this test failure as it didn't show up in the CI of PR: #34 Furthermore, the same issue existed as far back as #25 I tried to see whether this was introduced in one of the minor versions of Julia 0.5. But running the test now locally fails for all 0.5.0, 0.5.1 and 0.5.2. So, not sure what changed.
mauro3
added a commit
that referenced
this pull request
Aug 10, 2017
I'm a bit stomped by this test failure as it didn't show up in the CI of PR: #34 Furthermore, the same issue existed as far back as #25 I tried to see whether this was introduced in one of the minor versions of Julia 0.5. But running the test now locally fails for all 0.5.0, 0.5.1 and 0.5.2. So, not sure what changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems more in line with how folks talk about iterators in the base documentation. It will also help me in the way I am using this trait in Query.jl and my plans there (too long and complicated too explain ;).