Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AboutConditionals.java #80

Closed
wants to merge 3 commits into from
Closed

Update AboutConditionals.java #80

wants to merge 3 commits into from

Conversation

matyb
Copy link
Owner

@matyb matyb commented Feb 7, 2018

maybe it's convoluted, but this should close #75

maybe it's convoluted, but this should close #77
@Koan
public void bitwise() {
counter trueCount = new Counter(true);
counter falseCount = new Counter(false);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the Counter class contain a suitable constructor to initialize the returnValue attribute?

public Counter(boolean b) { this.returnValue = b; }

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, probably shouldn't edit java files on my phone 🥇

@matyb matyb closed this Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading comment on shortCircuit koan
2 participants