feat: mask apiKey in prompt and add async functions

mattzcarey · Aug 1, 2023 · cc95720 · cc95720
1 parent 4d287ff
commit cc95720
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/src/configure/index.ts b/src/configure/index.ts
@@ -23,6 +23,7 @@ export const configure = async () => {
       type: "input",
       name: "apiKey",
       message: "Please input your OpenAI API key:",
+      mask: "*",
     },
   ]);
 

diff --git a/src/test/index.ts b/src/test/index.ts
@@ -14,7 +14,7 @@ export const test = async ({ ci, model }: ReviewArgs) => {
   const maxPromptLength = getMaxPromptLength(model);
 
   // Fetch the test cases.
-  const testCases = loadTestCases(path.join(__dirname, "cases"));
+  const testCases = await loadTestCases(path.join(__dirname, "cases"));
 
   // Load the code snippets for the test cases. Generate them if they don't exist or are outdated.
   const testCasesWithSnippets = await loadOrGenerateCodeSnippets(

diff --git a/src/test/load/loadTestCases.ts b/src/test/load/loadTestCases.ts
@@ -1,4 +1,4 @@
-import { readFileSync, readdirSync } from "fs";
+import { readFile, readdir } from "fs/promises";
 import path from "path";
 import { TestCase } from "../types";
 import { logger } from "../../common/utils/logger";
@@ -8,9 +8,9 @@ import { logger } from "../../common/utils/logger";
  * @param testCasePath The path to the JSON test case file.
  * @returns The test case.
  */
-const loadTestCase = (testCasePath: string): TestCase => {
+const loadTestCase = async (testCasePath: string): Promise<TestCase> => {
   try {
-    const fileData = readFileSync(testCasePath, "utf8");
+    const fileData = await readFile(testCasePath, "utf8");
     return JSON.parse(fileData) as TestCase;
   } catch (error) {
     logger.error(`Error loading test case: ${testCasePath}`);
@@ -23,13 +23,19 @@ const loadTestCase = (testCasePath: string): TestCase => {
  * @param testCasesDir The directory containing the test cases.
  * @returns The test cases.
  */
-export const loadTestCases = (testCasesDir: string): TestCase[] => {
+export const loadTestCases = async (
+  testCasesDir: string
+): Promise<TestCase[]> => {
   try {
-    const testFiles = readdirSync(testCasesDir).filter((file) =>
+    const testFiles = (await readdir(testCasesDir)).filter((file) =>
       file.endsWith(".json")
     );
 
-    return testFiles.map((file) => loadTestCase(path.join(testCasesDir, file)));
+    return Promise.all(
+      testFiles.map(
+        async (file) => await loadTestCase(path.join(testCasesDir, file))
+      )
+    );
   } catch (error) {
     logger.error(`Error loading test cases from: ${testCasesDir}`);
     throw error;