fix: explicit exit code and return in review index

mattzcarey · Aug 7, 2023 · 9bb8140 · 9bb8140
1 parent 81097f1
commit 9bb8140
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/common/git/getFilesWithChanges.ts b/src/common/git/getFilesWithChanges.ts
@@ -15,7 +15,7 @@ export const getFilesWithChanges = async (
       logger.warn(
         "No files with changes found, you might need to stage your changes."
       );
-      exit();
+      exit(0);
     }
 
     const files = await Promise.all(

diff --git a/src/review/index.ts b/src/review/index.ts
@@ -10,7 +10,10 @@ import { askAI } from "./llm/askAI";
 import { constructPromptsArray } from "./prompt/constructPrompt/constructPrompt";
 import { filterFiles } from "./prompt/filterFiles";
 
-export const review = async (yargs: ReviewArgs, files: ReviewFile[]) => {
+export const review = async (
+  yargs: ReviewArgs,
+  files: ReviewFile[]
+): Promise<void> => {
   logger.debug(`Review started.`);
   logger.debug(`Model used: ${yargs.model}`);
   logger.debug(`Ci enabled: ${yargs.ci}`);
@@ -25,8 +28,8 @@ export const review = async (yargs: ReviewArgs, files: ReviewFile[]) => {
   const filteredFiles = filterFiles(files);
 
   if (filteredFiles.length == 0) {
-    logger.info("No file to review, exiting now.");
-    exit();
+    logger.info("No file to review, finishing review now.");
+    return;
   }
 
   logger.debug(