Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate key generation to blst #20

Merged
merged 16 commits into from
May 21, 2022
Merged

feat: migrate key generation to blst #20

merged 16 commits into from
May 21, 2022

Conversation

dev0x1
Copy link
Contributor

@dev0x1 dev0x1 commented May 19, 2022

  • remove existing bls12-381 pairing implementation
  • import blst
  • refactor dir structure to for common data structure
  • implement public error types
  • migrate SecretKey implementation to blst
  • remove G1 based public-key implementation

Fixes #15, #17

@dev0x1 dev0x1 requested a review from tplooker May 19, 2022 13:21
tplooker
tplooker reviewed May 19, 2022
View reviewed changes
src/common/secret_key.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 19, 2022
View reviewed changes
src/common/secret_key.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 19, 2022
View reviewed changes
src/common/secret_key.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 19, 2022
View reviewed changes
src/common/secret_key.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 19, 2022
View reviewed changes
src/common/secret_key.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 19, 2022
View reviewed changes
src/common/secret_key.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 19, 2022
View reviewed changes
src/common/util.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 19, 2022
View reviewed changes
src/common/secret_key.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 19, 2022
View reviewed changes
src/common/secret_key.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 19, 2022
View reviewed changes
src/common/secret_key.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 19, 2022
View reviewed changes
src/common/secret_key.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 19, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 19, 2022
View reviewed changes
src/common/error.rs Outdated Show resolved Hide resolved
dev0x1 and others added 8 commits May 20, 2022 08:34
@dev0x1
chore: remove hkdf package
c99cb46
@dev0x1 @tplooker
fix: accept review comment
21c8f7a 
Co-authored-by: Tobias Looker <[email protected]>
@dev0x1 @tplooker
fix: accept review comment
54f0b8e 
Co-authored-by: Tobias Looker <[email protected]>
@dev0x1 @tplooker
fix: accept review comment
a6dcdf2 
Co-authored-by: Tobias Looker <[email protected]>
@dev0x1 @tplooker
fix: accept review comment
a60849f 
Co-authored-by: Tobias Looker <[email protected]>
@dev0x1
feat: base SecretKey upon blstrs::Scalar
28c2572 
- using blstrs::Scalar gives a bit abstraction over blst_scalar
- we can switch or additionally support any `ff` and `group` based impl
@dev0x1
feat: migrating public key generation to blst
d1152b7 
Fixes #16
@dev0x1
chore: cargo fmt
d459836
@dev0x1 dev0x1 marked this pull request as ready for review May 21, 2022 05:14
tplooker
tplooker reviewed May 21, 2022
View reviewed changes
src/common/public_key.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 21, 2022
View reviewed changes
src/common/error.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 21, 2022
View reviewed changes
src/common/error.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 21, 2022
View reviewed changes
src/common/error.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 21, 2022
View reviewed changes
src/common/error.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 21, 2022
View reviewed changes
src/common/error.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 21, 2022
View reviewed changes
src/common/error.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 21, 2022
View reviewed changes
src/common/error.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 21, 2022
View reviewed changes
src/common/error.rs Outdated Show resolved Hide resolved
tplooker
tplooker reviewed May 21, 2022
View reviewed changes
src/common/secret_key.rs Outdated Show resolved Hide resolved
@tplooker
Copy link
Member

Looking good, very minor tweaks just to make the error messages a little bit more consistent

tplooker
tplooker approved these changes May 21, 2022
View reviewed changes
Copy link
Member

@tplooker tplooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tplooker tplooker merged commit c2859cc into master May 21, 2022
@tplooker
Copy link
Member

Merging with broken CI as @dev0x1 will address the new public API for the crate in a seperate PR

@tplooker tplooker deleted the dev0x1/issue15 branch May 21, 2022 22:54
This was referenced May 21, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BasileiosKal BasileiosKal BasileiosKal left review comments

@tplooker tplooker tplooker approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrating key generation to blst
3 participants
@dev0x1 @tplooker @BasileiosKal