Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hyuga installer #614

Merged
merged 10 commits into from
Jan 6, 2024
Merged

Added Hyuga installer #614

merged 10 commits into from
Jan 6, 2024

Conversation

sakuraiyuta
Copy link
Contributor

This PR adds Hy Language Server for Hy 0.24.0.

https://github.com/sakuraiyuta/hyuga

@mattn
Copy link
Owner

mattn commented Sep 10, 2022

Thanks your contribution. Why don't you use pip_install.cmd ? Could you please explain why --system-site-package is required?

@sakuraiyuta
Copy link
Contributor Author

sakuraiyuta commented Sep 20, 2022

@mattn Thank you for reply.

Could you please explain why --system-site-package is required?

Hyuga supports to search system installed packages. This feature needs to use --system-site-package.
In my opinion, some python developer want to use them.
(Yes, it's so dirty...but a way for users can dare to select.)

It seems no methods to pass through option arguments to pip_install.{sh,cmd}, so I avoided to use pip_install script.
Any ideas? Or should drop it?

Other way: Add options to lsp settings in initialize, e.g. additional-path: {system installed packages dir} like root-uri.

@mattn
Copy link
Owner

mattn commented Oct 8, 2022

Thanks. So could you please update README Local Install to No? (If my understainding is right)

@mattn
Copy link
Owner

mattn commented Jan 6, 2024

Now ready to merge this?

@sakuraiyuta
Copy link
Contributor Author

Sorry for waiting you...ready now!

@mattn mattn merged commit 223c738 into mattn:master Jan 6, 2024
14 checks passed
@mattn
Copy link
Owner

mattn commented Jan 6, 2024

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants