Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce GIT_* environment variables to specify git metadata #188

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

gdm85
Copy link
Collaborator

@gdm85 gdm85 commented Nov 3, 2020

This PR does the following:

If/when merged all users who currently are using GitHub Actions and have a failing git fetch will start to see the failure; it is correct that they are affected by this breaking change and take action by either turning off the feature with -allowgitfetch=false or fix their GitHub Action, otherwise they will keep ignoring the error and sending invalid/missing git metadata information to coveralls.io.

Current behaviour with ignored error was introduced in 421981d

Introduce -allowgitfetch=true CLI option to cover current implicit behavior with GitHub Actions
Fail goveralls in case git fetch fails
@gdm85 gdm85 force-pushed the fix/git-fetch-and-env branch from 9cf77b1 to bfda67b Compare November 3, 2020 19:08
@coveralls
Copy link

coveralls commented Nov 3, 2020

Coverage Status

Coverage decreased (-0.5%) to 11.208% when pulling bfda67b on fix/git-fetch-and-env into 28a623e on master.

Copy link
Collaborator

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdm85 gdm85 merged commit 50ffb11 into master Nov 4, 2020
@gdm85 gdm85 deleted the fix/git-fetch-and-env branch November 4, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw Error when collectGitInfo fails
3 participants