Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: findProxyForURL when !cgo #43

Merged
merged 1 commit into from
Sep 16, 2022
Merged

fix: findProxyForURL when !cgo #43

merged 1 commit into from
Sep 16, 2022

Conversation

caarlos0
Copy link
Contributor

@caarlos0 caarlos0 commented Sep 16, 2022

should fix #34 (comment)

also added tests CGO_ENABLED to the test matrix

Signed-off-by: Carlos A Becker <[email protected]>
@caarlos0 caarlos0 marked this pull request as ready for review September 16, 2022 01:08
@caarlos0 caarlos0 mentioned this pull request Sep 16, 2022
@mattn mattn merged commit 7343ac5 into mattn:master Sep 16, 2022
@mattn
Copy link
Owner

mattn commented Sep 16, 2022

Thank you. Will tag soon.

@caarlos0 caarlos0 deleted the fix-macos-cgo branch September 16, 2022 02:15
chrislusf added a commit to seaweedfs/seaweedfs that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build fails on darwin
2 participants