Skip to content

Comments

fix: "try" methods should never throw#176

Merged
mattjohnsonpint merged 3 commits intomainfrom
mjp/no-exceptions-from-try
Oct 17, 2025
Merged

fix: "try" methods should never throw#176
mattjohnsonpint merged 3 commits intomainfrom
mjp/no-exceptions-from-try

Conversation

@mattjohnsonpint
Copy link
Owner

Invalid input to any of the Try... methods should return false, not throw an exception.

Fixes #154

@mattjohnsonpint mattjohnsonpint merged commit bc92e05 into main Oct 17, 2025
3 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/no-exceptions-from-try branch October 17, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion: Don't throw an exception from TzConvert.TryGetTimeZone if the time zone id string is null.

1 participant