Fixed bug during loading of attributes #112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jannis Hollmann <[email protected]>
matthias-k
reviewed
Jul 16, 2025
| __attributes__ = json.loads(json_attributes) | ||
|
|
||
| attributes = {attribute: load_hdf5_dataset(attribute_group, attribute) for attribute in __attributes__} | ||
| attributes = {attribute: attribute_group[attribute][...] for attribute in __attributes__} |
Owner
There was a problem hiding this comment.
load_hdf5_dataset should handle string attributes. Removing it will fail to load string attributes. There is a test for this, which is now failing (For some reason, the tests didn't run automatically here, but I needed to trigger them)
Owner
|
Can you add a test that fails with the old code to make sure that the problem doesn't come back? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent bugfix #111 introduced a bug where attributes were only read once per load instead of for each stimulus individually.