Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change in SENSOR_TYPE_WEATHER2 handling #224

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

matthias-bs
Copy link
Owner

@matthias-bs matthias-bs commented Jan 29, 2025

sensor[slot].w.tglobe_c is now updated even if its value indicates 'invalid'. This will simplify handling in BresserWeatherSensorLW, because

  1. The tglobe_valid flag will not be part of the LoRaWAN message payload.
  2. The payload has to be fixed, i.e. tglobe_c is either transmitted or not — regardless of its value.

@matthias-bs matthias-bs self-assigned this Jan 29, 2025
@matthias-bs matthias-bs added the enhancement New feature or request label Jan 29, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13038184168

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 13015132515: 0.0%
Covered Lines: 215
Relevant Lines: 215

💛 - Coveralls

@matthias-bs matthias-bs merged commit 57f1d85 into main Jan 29, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants