Merged
Conversation
Signed-off-by: Matthew Yeung <yyygggfff@hotmail.com>
matthewygf
added a commit
that referenced
this pull request
Jan 5, 2026
* Add build workflow check Signed-off-by: Matthew Yeung <yyygggfff@hotmail.com> * Update Dockerfile paths in build workflow Signed-off-by: Matthew Yeung <yyygggfff@hotmail.com> * Enable submodules in build workflow Signed-off-by: Matthew Yeung <yyygggfff@hotmail.com> * Add Pre-Commit & GitHub actions (#1) * Add Pre-commit lint & build test workflow action --------- Signed-off-by: Matthew Yeung <yyygggfff@hotmail.com> * Update build-and-test.yml - because the host-ip variable cannot work here yet, so temporarily pass for the bridgeip Signed-off-by: Matthew Yeung <yyygggfff@hotmail.com> * Add pull-requests permission to workflow Signed-off-by: Matthew Yeung <yyygggfff@hotmail.com> * Remove test report publishing step Removed the test report publishing step from the workflow. Signed-off-by: Matthew Yeung <yyygggfff@hotmail.com> * Add workflow to publish test results Signed-off-by: Matthew Yeung <yyygggfff@hotmail.com> * enhance reports xml * Fix formatting in build-and-test workflow Signed-off-by: Matthew Yeung <yyygggfff@hotmail.com> * Fix formatting in report-test-results.yml Signed-off-by: Matthew Yeung <yyygggfff@hotmail.com> * Fix error message formatting in managed_mem.cpp Signed-off-by: Matthew Yeung <yyygggfff@hotmail.com> --------- Signed-off-by: Matthew Yeung <yyygggfff@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several key improvements to the development workflow and code quality enforcement for the project. The main changes include adding a comprehensive CI workflow for linting and testing on Ascend 910B hardware, introducing pre-commit hooks for code quality, and enhancing Python code style consistency. Additionally, minor documentation and code formatting updates are included.
CI/CD and Code Quality Automation:
.github/workflows/build-and-test.yml) to run lint checks and execute unit tests on Ascend 910B hardware using a containerized environment, with automated log upload and test reporting.Pre-commit Hooks and Linting:
.pre-commit-config.yamlfile to enable automated checks for SPDX headers, Python import sorting (isort), code formatting (ruff), spell checking (codespell), C++ formatting (clang-format), and type checking (mypy) from upstream.Code Style and Documentation:
benchmark/v1/rag/analysis.pyandbenchmark/v1/rag/rag.py, including import reordering, string normalization, and better argument parsing.README.mdfor improved clarity.These changes collectively improve the project's code quality, enforce best practices, and streamline CI for both development and deployment.