Strip text before adding blockquote markers #76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
@johannesdewit and I noticed there are quite a few cases where converted blockquotes generate redundant
>
markers, for example when newlines are inside the blockquote:But also when nesting a paragraph inside a blockquote tag:
And finally, nesting blockquotes:
If we apply a simple
.strip()
on the text before adding the blockquote markers, we can avoid these all. I have done that in this PR, and it produces these results:Also note that it still preserves blockquote markers between paragraphs, e.g.:
This PR also incorporates these examples in the tests.