Use a conversion function cache to improve runtime #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispy-snps
force-pushed
the
chrispy/use-conversion-function-cache
branch
from
20fb336 to
200bff8
Compare
Signed-off-by: chrispy <[email protected]>
chrispy-snps
force-pushed
the
chrispy/use-conversion-function-cache
branch
from
200bff8 to
376f253
Compare
AlexVonB
approved these changes
Feb 24, 2025
|
@AlexVonB in my testing, it was about an 8% speedup (on top of all the recent speedups we've had). |
|
Great, lets go! 🥳 |
Wuhall
pushed a commit
to Wuhall/python-markdownify
that referenced
this pull request
May 21, 2025
Signed-off-by: chrispy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a conversion function cache to improve runtime.
This also organizes and simplifies the code related to evaluating conversion functions a bit more nicely.