improve text normalization/escaping for preformatted/code contexts #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrispy <[email protected]>
chrispy-snps
force-pushed
the
fix/97-101-102
branch
from
95d9bbc to
2b22d23
Compare
This was
linked to
issues
Jan 15, 2024
AlexVonB
approved these changes
Jan 15, 2024
Wuhall
pushed a commit
to Wuhall/python-markdownify
that referenced
this pull request
May 21, 2025
improve text normalization/escaping for preformatted/code contexts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following:
<span>tags inside<pre><code>blocks are incorrectly escaped in Markdown output #101<kbd>and<samp>are incorrectly escaped, whereas underscores in<code>are correctly not escaped #102The fix uses Beautiful Soup's
find_parent()method to see if any containing element up the parent/ancestor tree matches the specified pattern.