Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix null httpServer error during build and check, fixes #19 #20

Merged
merged 1 commit into from
May 4, 2023

Conversation

smnbbrv
Copy link
Contributor

@smnbbrv smnbbrv commented Mar 22, 2023

The vite dev server seem to run in middleware mode (httpServer is null in this case), that's why we need to create an own server to pass into fastify constructor

@tarekwiz
Copy link

Can you please accept this pull request?

@matthewp
Copy link
Owner

matthewp commented May 4, 2023

Yep, thanks!

@matthewp matthewp merged commit 1b4d510 into matthewp:main May 4, 2023
@matthewp matthewp mentioned this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants