Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix string formatting in error message #216

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

jameslamb
Copy link
Contributor

@jameslamb jameslamb commented May 11, 2024

Thanks for this awesome project!

I noticed tonight that an error message is printing with the literal string f{lib_path} in it, like this:

delocate.libsana.DelocationError: f{lib_path} already exists in wheel but need to copy /opt/homebrew/Cellar/libomp/17.0.6/lib/libomp.dylib

I strongly suspect that was supposed to be an f-string, where {lib_path} is replaced in the error message with a path to a library.

This proposes that fix.

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.93%. Comparing base (7f46f89) to head (e4c8b64).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files          16       16           
  Lines        1307     1307           
=======================================
  Hits         1267     1267           
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HexDecimal HexDecimal self-assigned this Jun 7, 2024
HexDecimal added a commit to HexDecimal/delocate that referenced this pull request Jun 7, 2024
HexDecimal added a commit to HexDecimal/delocate that referenced this pull request Jun 7, 2024
HexDecimal added a commit to HexDecimal/delocate that referenced this pull request Jun 7, 2024
@HexDecimal
Copy link
Collaborator

I apologize for getting around to this PR so late. I've rebased the PR and updated the changelog and the relevant tests. Tests for DelocationError were missing a match= argument.

@jameslamb
Copy link
Contributor Author

No problem, and thanks very much!

@HexDecimal HexDecimal merged commit 846f5b5 into matthew-brett:master Jun 7, 2024
17 checks passed
@jameslamb jameslamb deleted the fix/error-message branch June 7, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants