If wheel has no package directories, use lib_sdir as a suffix #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
=======================================
Coverage 96.93% 96.93%
=======================================
Files 16 16
Lines 1307 1307
=======================================
Hits 1267 1267
Misses 40 40 ☔ View full report in Codecov by Sentry. |
|
Sorry for taking so long to respond. I've rebased the PR, updated a test, and documented the feature better. I think your implementation fits well with the existing API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to customize libs dir if the wheel has no package directory.
One use case is an extension, that offers C-API (like the gmpy2 package). With above patch you could set one to something common for all platforms.