-
Notifications
You must be signed in to change notification settings - Fork 62
Validate and update macOS platform tag in wheel name #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HexDecimal
merged 36 commits into
matthew-brett:master
from
Czaki:macholib_version_check
Feb 17, 2024
Merged
Changes from 31 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
efa212e
initial implementation
Czaki c3a35e5
use Path
Czaki 670bb76
change regexp name
Czaki d242da7
add set type annotation
Czaki 93b17d9
extract logic to separate function, update function names
Czaki 5dad39d
add basic tests
Czaki 3570f59
add test for universal2
Czaki 2078633
apply changes from code review
Czaki 07c3976
fix test part 1
Czaki 6885624
fix mypy
Czaki a56ec61
update changelog
Czaki c086486
fix test 2
Czaki 6332cb5
verbose run
Czaki 7726378
change name of wheel
Czaki 0bbbbad
provide flag
Czaki b109f7b
improve exception
Czaki 6ba5099
fix test
Czaki d0d99c6
add tests
Czaki 0fd885d
add tests
Czaki 2b6a3e1
fix calling by absolute path
Czaki fc081af
Apply suggestions from code review
Czaki b939a1e
add mised type
Czaki d65946c
remove old wheel
Czaki 046fcab
fix updating metadata and add testing it
Czaki 2486313
add docstrings
Czaki 048b256
fix mypy
Czaki e972852
fix wrong variable name
Czaki 89871b9
Apply suggestions from code review
Czaki 987dc95
Apply suggestions from code review
Czaki 5ce9344
next fixes from code review
Czaki 2f13b20
fix pre-commit formatting
Czaki 9b8aaca
Update delocate/tests/test_scripts.py
Czaki bd85986
pre-commit fix
Czaki 222033d
fix reporting problematic libs for x86_64
Czaki e2979a1
add assetr for testing
Czaki 51f03fc
add comment with explanation
Czaki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.