-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search in /usr/local/lib and /usr/lib like the system loader #167
Conversation
This is ready for review. mypy failure seems to be unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I trust the tests more than my ability to read the code right now. You can rebase/merge if you want to fix the Mypy error. I only have aesthetic suggestions for code changes.
I never knew startswith could take a tuple.
If this is blocking a project then I can make a new release shortly after this is merged. |
One more thing. This needs an addition to the changelog. |
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 95.45% 95.47% +0.02%
==========================================
Files 14 14
Lines 1077 1084 +7
==========================================
+ Hits 1028 1035 +7
Misses 49 49
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
7742b97
to
55fb945
Compare
Fixes #155 and fixes the issues in numpy/numpy#22525