-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with libcompression.dylib and delocate 0.9 #119
Comments
@HexDecimal - any ideas here? I guess this is the refactor? |
downgrading to |
The recursive dependency resolver noticed that the system library This might have happened because of the differences in how |
Aha - thanks for that analysis. I guess this is, in fact, a genuine error, in that it is not possible, in this case, to recreate the behavior of the code on the system, without copying the system lib. |
I can add a fix to #118 or add a fix in a separate PR. Depending on the rpaths of system libraries it might be possible to create a test to check this. |
I think the best option would be to have |
Or maybe you can keep them separate to define intent, but combining them internally will resolve this issue. |
That was partly my point about this being a genuine error - in that the |
Combines lib_flit_func and copy_flit_func behavior into one function. This makes sure that a file which won't be copied will not have its dependencies analyzed. Fixes matthew-brett#119
I guess my question here is - should we raise a more informative error here? Or just pass silently by? |
I'm preparing a fix with #120. There won't be an error, files which aren't copied will no longer be followed. So Delocate will no longer have non-copied libraries depending on copied libraries. |
Combines lib_flit_func and copy_flit_func behavior into one function. This makes sure that a file which won't be copied will not have its dependencies analyzed. Fixes matthew-brett#119 Since the previous behavior is assumed to be wrong the tests have been updated.
MRG: Don't follow libraries which won't be copied. Combines `lib_flit_func` and `copy_flit_func` behavior into one function. This makes sure that a file which won't be copied will not have its dependencies analyzed. Fixes #119
thanks! |
MRG: Don't follow libraries which won't be copied. Combines `lib_flit_func` and `copy_flit_func` behavior into one function. This makes sure that a file which won't be copied will not have its dependencies analyzed. Fixes matthew-brett#119
I suddenly start experiencing issues running delocate building our binary wheels, it looks like delocate is trying to modify system libraries and fails to do so.
delocate version 0.9 only, downgrading to 0.8.2 seems to resolve the issue.
python version 3.6, 3.7, 3.8, 3.9 (pyenv) on OS X 10.15 (github actions).
output:
full build can be found here:
https://github.com/MonetDBSolutions/MonetDBe-Python/runs/3201098936?check_suite_focus=true
The text was updated successfully, but these errors were encountered: