remove unscoped todo's

mattfenwick · Jan 17, 2023 · 330c050 · 330c050
1 parent ae9d23b
commit 330c050
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/pkg/connectivity/probe/resources.go b/pkg/connectivity/probe/resources.go
@@ -198,7 +198,7 @@ func (r *Resources) CreateService(svc *v1.Service) (*Resources, error) {
 	}
 	newServices := map[string]*v1.Service{}
 	for oldServiceName, oldService := range r.Services {
-		newServices[oldServiceName] = oldService // TODO: service type is pointer, duplicate resource type needs to be deep copied, just following paradigm for now
+		newServices[oldServiceName] = oldService // Note: service type is pointer, duplicate resource type needs to be deep copied
 	}
 	newServices[svc.Name] = svc
 	return &Resources{

diff --git a/pkg/generator/loadbalancertestcases.go b/pkg/generator/loadbalancertestcases.go
@@ -8,7 +8,6 @@ import (
 )
 
 func (t *TestCaseGenerator) LoadBalancerTestCase() []*TestCase {
-	// TODO: simplify this struct passed to CreateService
 	svc1 := &v1.Service{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      "test-service-name",
@@ -51,7 +50,7 @@ func (t *TestCaseGenerator) LoadBalancerTestCase() []*TestCase {
 		NewTestCase("should allow access to nodeport with no netpols applied",
 			NewStringSet(TagLoadBalancer),
 			NewTestStep(probe,
-				CreateService(svc1), // TODO: add service reset, without removing core test services
+				CreateService(svc1),
 			),
 		),
 		NewTestCase("should deny access to nodeport with netpols applied",