Use release-X.Y tags for plugin SpinWick Mattermost images

[nickmisasi]

Summary

Plugin SpinWicks pull mattermostdevelopment/mattermost-enterprise-edition, which publishes branch tags like release-11.10, not the bare semver tags (11.10.0) returned by resolveMattermostServerVersion(). Map resolved versions to release-X.Y before creating the Cloud installation so plugin SpinWicks can pull an image that exists. Desktop/mobile E2E paths are unchanged.

Release Note

NONE

Made with Cursor

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 35864fd0-5a04-4525-b92f-c363eb70b394

📥 Commits

Reviewing files that changed from the base of the PR and between 74a422f and 6869b08.

📒 Files selected for processing (1)

• server/spinwick_plugin.go

🚧 Files skipped from review as they are similar to previous changes (1)

• server/spinwick_plugin.go

---

📝 Walkthrough

Walkthrough

SpinWick now converts valid Mattermost semantic versions into release-major.minor image tags. It preserves special and invalid values, trims whitespace, and applies the mapping during plugin installation. Tests cover the supported input cases.

Changes

SpinWick image tag normalisation

Layer / File(s)	Summary
Version parsing and coverage server/spinwick_plugin.go, server/spinwick_plugin_test.go	pluginSpinwickImageTag trims versions, preserves empty, master, release-*, and invalid values, and converts valid semantic versions to release-major.minor tags. Table-driven tests cover these cases.
Installation tag integration server/spinwick_plugin.go	Plugin creation applies the normalised tag to the resolved Mattermost version while retaining release-candidate resolution.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to 6869b

The change maps resolved versions to release-X.Y tags for SpinWick Mattermost image installation. An inaccurate comment remains in server/spinwick_plugin.go and should be corrected or explicitly accepted by the owner, but no production behavior or merge-blocking failure is identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: mapping SpinWick Mattermost image versions to release-X.Y tags.
Description check	✅ Passed	The description directly explains the tag mismatch, the version mapping, and the unchanged E2E paths.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/plugin-spinwick-release-tag

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@server/spinwick_plugin.go`:
- Around line 77-80: Update the comment above pluginSpinwickImageTag and
resolveMattermostServerVersion to state that the installation uses the
configured version unless E2EServerVersion is "latest"; only the "latest"
configuration resolves to the highest available server version, including RCs.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4f76946e-8fbd-414b-936a-8d3bf1c8d0d5

📥 Commits

Reviewing files that changed from the base of the PR and between da38ec0 and 74a422f.

📒 Files selected for processing (2)

• server/spinwick_plugin.go
• server/spinwick_plugin_test.go

[yasserfaraazkhan]

🎉