Skip to content

fix(cmt): use macos-26 and ubuntu-latest for desktop CMT matrix - #93

Merged
yasserfaraazkhan merged 1 commit into
masterfrom
fix/cmt-desktop-macos-26-runners
Jul 28, 2026
Merged

fix(cmt): use macos-26 and ubuntu-latest for desktop CMT matrix#93
yasserfaraazkhan merged 1 commit into
masterfrom
fix/cmt-desktop-macos-26-runners

Conversation

@yasserfaraazkhan

@yasserfaraazkhan yasserfaraazkhan commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Desktop CMT hardcodes macos-13 / ubuntu-22.04 in buildDesktopCMTMatrixJSON
  • macos-13 is retired by GitHub, so RC CMT macOS jobs queue forever (seen on desktop CMT run 30258289129)
  • Send macos-26 + ubuntu-latest instead, matching desktop PR E2E

Test plan

  • go test ./server/ -run 'TestDryRun_DesktopCMT|TestE2E' -count=1
  • Merge, tag v0.4.16, bump gitops-platform image (gitops#78)
  • After deploy: re-run Desktop CMT Provisioner and confirm macOS jobs start on macos-26
NONE

macos-13 is retired and queues forever; align CMT runners with desktop
PR E2E so RC-tag dispatches do not hang on unavailable labels.

Co-authored-by: Cursor <cursoragent@cursor.com>
@mm-cloud-bot mm-cloud-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 27, 2026
@mm-cloud-bot

Copy link
Copy Markdown

@yasserfaraazkhan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

I understand the commands that are listed here

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The desktop CMT matrix now uses updated Linux and macOS runners. The schema test explicitly verifies the Linux, macOS, and Windows runner mappings.

Changes

Desktop CMT runners

Layer / File(s) Summary
Update and validate desktop runner mappings
server/workflow_run.go, server/e2e_dryrun_test.go
The matrix changes Linux to ubuntu-latest and macOS to macos-26; the schema test asserts these mappings along with Windows windows-2022.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly names the desktop CMT matrix runner update and matches the changeset.
Description check ✅ Passed The description directly explains the same runner-label update and why it was needed.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cmt-desktop-macos-26-runners

Comment @coderabbitai help to get the list of available commands.

@yasserfaraazkhan yasserfaraazkhan added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed labels Jul 27, 2026
@mm-cloud-bot

Copy link
Copy Markdown

@yasserfaraazkhan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

I understand the commands that are listed here

@mm-cloud-bot mm-cloud-bot added do-not-merge/release-note-label-needed and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 27, 2026
@yasserfaraazkhan yasserfaraazkhan added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed labels Jul 27, 2026
@mm-cloud-bot

Copy link
Copy Markdown

@yasserfaraazkhan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

I understand the commands that are listed here

@mm-cloud-bot mm-cloud-bot added do-not-merge/release-note-label-needed and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 27, 2026
@yasserfaraazkhan yasserfaraazkhan added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 27, 2026
@mm-cloud-bot mm-cloud-bot removed the release-note-none Denotes a PR that doesn't merit a release note. label Jul 27, 2026
@yasserfaraazkhan yasserfaraazkhan added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed labels Jul 27, 2026
@mm-cloud-bot

Copy link
Copy Markdown

@yasserfaraazkhan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

I understand the commands that are listed here

@mm-cloud-bot mm-cloud-bot added do-not-merge/release-note-label-needed release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/release-note-label-needed labels Jul 27, 2026
@saturninoabril saturninoabril added the 4: Reviews Complete All reviewers have approved the pull request label Jul 28, 2026
@yasserfaraazkhan
yasserfaraazkhan merged commit e21db79 into master Jul 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants