Skip to content

Fix: suppress error comment on unsupported repos for E2E label - #84

Merged
saturninoabril merged 2 commits into
masterfrom
fix-comment
Mar 18, 2026
Merged

Fix: suppress error comment on unsupported repos for E2E label#84
saturninoabril merged 2 commits into
masterfrom
fix-comment

Conversation

@yasserfaraazkhan

@yasserfaraazkhan yasserfaraazkhan commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Fixes posting comment on other repos other than mobile and desktop.

example : mattermost/mattermost#35541 (comment)

NONE

Summary by CodeRabbit

  • Bug Fixes
    • Removed a redundant error comment when the system couldn't determine the end-to-end instance, reducing unnecessary notifications.
    • Stopped posting a “E2E started” comment after triggering workflows to cut down on repetitive status messages.

When E2E/Run label is added to a repo that is neither desktop nor
mobile, silently log and return instead of posting an error comment.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 17, 2026
@coderabbitai

coderabbitai Bot commented Mar 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cc581127-d668-4298-a758-dc09e232d2ef

📥 Commits

Reviewing files that changed from the base of the PR and between b8f2dbb and 5bb5f55.

📒 Files selected for processing (1)
  • server/e2e_tests.go
💤 Files with no reviewable changes (1)
  • server/e2e_tests.go

📝 Walkthrough

Walkthrough

The pull request removes user-facing E2E comment postings: it no longer posts an error comment when the E2E instance type cannot be determined from the repository name, and it no longer posts an "E2E started" comment after successfully triggering the workflow.

Changes

Cohort / File(s) Summary
E2E Comment Posting
server/e2e_tests.go
Removed posting of an error comment when instance type cannot be determined; removed posting of an "E2E started" comment after triggering the workflow; function now returns early in the error case.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly describes the main change: suppressing error comments when E2E/Run label is added to unsupported repositories.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

Avoids posting multiple "E2E Test Servers Created" comments when the
label is added multiple times on desktop/mobile PRs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@saturninoabril saturninoabril left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saturninoabril saturninoabril added the 4: Reviews Complete All reviewers have approved the pull request label Mar 18, 2026
@saturninoabril
saturninoabril merged commit e87a785 into master Mar 18, 2026
3 checks passed
@saturninoabril
saturninoabril deleted the fix-comment branch March 18, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants