Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Test cases for Scheduled Message feature #183

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

yasserfaraazkhan
Copy link
Collaborator

Copy link
Member

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yasserfaraazkhan! Added some comments on additional cases we want to include.

Also, for the first version I believe we will be supporting moving a draft to a scheduled post. Is this correct @harshilsharma63 ? If so, we need to include test cases for add/remove schedule to drafts

1. Log into User's account.
2. Type a message in the GM/Channel post text box.
3. Click on the Dropdown beside Send button.
4. Choose a pre-defined Date from the options.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we verify the timezone behavior for scheduling? I believe the expected behavior is the date and time dialog is in the users configured timezone, can you confirm @harshilsharma63 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats correct, it should be in the user's configured TZ, not the timezone of the browser.

Copy link
Collaborator

@lindalumitchell lindalumitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @yasserfaraazkhan! I added a bunch of nitpicky suggestions, plus I've started auditing the priorities set on our test cases, so these should be P3 in our custom priority field, as noted. Approving since the substance looks great; you can decide about my suggestions. :)

data/test-by-folder.json Outdated Show resolved Hide resolved
data/test-by-folder.json Outdated Show resolved Hide resolved
data/test-by-folder.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@lindalumitchell lindalumitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @yasserfaraazkhan! I added a bunch of nitpicky suggestions, plus I've started auditing the priorities set on our test cases, so I marked that these should be P3 in our custom priority field. Approving since the substance looks great on the test cases; you can decide about my suggestions. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants