Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tests for root post delete helper plugin #182

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

saturninoabril
Copy link
Member

Summary

Tests for root post delete helper plugin

Is the feature in stable branch or under review?

  • Feature in stable branch (master, main)?

https://github.com/mattermost/mattermost-plugin-post-delete-helper

Test client

  • Browser
  • [] Mobile App (version, OS)
  • Desktop App (version, OS)

@saturninoabril saturninoabril added 2: Dev Review Requires review by a core committer 2: QA Review Requires review by a QA tester labels Sep 13, 2024
Copy link
Collaborator

@lindalumitchell lindalumitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look great, thanks @saturninoabril !

  1. I agree with your questions / comments about the slash command functions. Adding a couple comments/questions as well.
  2. Wondering if these tests should be marked P3 - Deep Functions (Do extensive scenarios work?) instead of P2 - Core Functions (Do core functions work?)?
  • I think the primary way we would use the priority field is in relation to the overall product. So while these are core functions of the plugin itself, perhaps the plugin functions wouldn't be prioritized as core functions of the overall product. What do you think? I know this field isn't necessarily consistent in this way across all test cases, but would be a good time to start aligning, I think.

@saturninoabril
Copy link
Member Author

I agree and really good point! Now updated.

Having these priority consistent would make it easier to edit on how we're doing test coverage per priority level.

@saturninoabril
Copy link
Member Author

@wiggin77 @lindalumitchell Please take a look again, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer 2: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants