-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tests for root post delete helper plugin #182
Open
saturninoabril
wants to merge
4
commits into
main
Choose a base branch
from
plugin-post-delete-helper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
added
2: Dev Review
Requires review by a core committer
2: QA Review
Requires review by a QA tester
labels
Sep 13, 2024
saturninoabril
commented
Sep 13, 2024
saturninoabril
commented
Sep 13, 2024
saturninoabril
commented
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look great, thanks @saturninoabril !
- I agree with your questions / comments about the slash command functions. Adding a couple comments/questions as well.
- Wondering if these tests should be marked
P3 - Deep Functions (Do extensive scenarios work?)
instead ofP2 - Core Functions (Do core functions work?)
?
- I think the primary way we would use the priority field is in relation to the overall product. So while these are core functions of the plugin itself, perhaps the plugin functions wouldn't be prioritized as core functions of the overall product. What do you think? I know this field isn't necessarily consistent in this way across all test cases, but would be a good time to start aligning, I think.
I agree and really good point! Now updated. Having these priority consistent would make it easier to edit on how we're doing test coverage per priority level. |
@wiggin77 @lindalumitchell Please take a look again, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tests for root post delete helper plugin
Is the feature in stable branch or under review?
https://github.com/mattermost/mattermost-plugin-post-delete-helper
Test client