Added the test cases for the image in the comment notification. #159
+52
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on. (#33) * [MM-93]: Added the test cases for the image in the comment notification. * [MM-93]: Fixed the changes required for connect flow.
|
This looks good @arush-vashishtha. It's nice to see coverage this deep on the functionality. The script is fine. I will approve for merge once I confirm if we need any further validation of the Zephyr test data. |
saturninoabril
requested changes
May 8, 2024
There was a problem hiding this comment.
Thanks @arush-vashishtha! Left couple of comments. Lastly, please organized the steps/expected format as also commented at #161 (review).
| name: "Image attachment properly shown in the comment notification." | ||
| status: Active | ||
| priority: Normal | ||
| folder: Subscriptions-and-notifications |
There was a problem hiding this comment.
Should be
Suggested change
| folder: Subscriptions-and-notifications | |
| folder: Subscriptions and Notifications |
| **Expected** | ||
|
|
||
| The comment notification in the desired channel or DM/GM on MM should show the proper image attached to the desired `issue` or `merge request` on Gitlab. | ||
| After step 2, the comment notification in the desired channel or DM/GM on MM should show the proper embedded image in the comment on desired `issue` or `merge reuest` on Gitlab. |
There was a problem hiding this comment.
Suggested change
| After step 2, the comment notification in the desired channel or DM/GM on MM should show the proper embedded image in the comment on desired `issue` or `merge reuest` on Gitlab. | |
| After step 2, the comment notification in the desired channel or DM/GM on MM should show the proper embedded image in the comment on desired `issue` or `merge request` on Gitlab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR consists the test cases for the notification on MM of the Image attached to a comment in a issue or merge request on Gitlab.