Merged
Conversation
jfrerich
approved these changes
Sep 22, 2020
jfrerich
left a comment
jfrerich
left a comment
There was a problem hiding this comment.
Removing the need for make apply would be awesome!
The command is already tied in to the Make commands, but accessing plugin.json as a single source of truth will also be great 🎉
hanzei
added
the
4: Reviews Complete
lieut-data
added a commit
that referenced
this pull request
Dec 12, 2023
This reverts commit 18d30b5.
lieut-data
added a commit
that referenced
this pull request
Jan 23, 2024
#192) * Revert "Update main.go (#154)" This reverts commit be4a281. * Revert "[MM-33506] Use embed package to include plugin manifest (#145)" This reverts commit ca9ee3c. * Revert "Don't generate manifest.ts (#127)" This reverts commit 18d30b5. * install-go-tools target, adopt gotestsum * bring back make apply + automatic versioning * Update build/manifest/main.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * suppress git describe error when no tags match * make version/release notes opt-in * fix whitespace in Makefile * document version management options --------- Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instead of generating
manifest.tsviamake applythe code simply reads it from the json file.We might be able to drop
make applycompletely in the future.Ticket Link
None